Documentation: Outdated fluentd image name, UID details, link update #2112
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…, and link to installing as container
|
|
Codecov Report
@@ Coverage Diff @@
## master #2112 +/- ##
=======================================
Coverage 61.25% 61.25%
=======================================
Files 146 146
Lines 11193 11193
=======================================
Hits 6856 6856
Misses 3791 3791
Partials 546 546 |
cyriltovena
reviewed
May 22, 2020
docs/clients/fluentd/README.md
Outdated
| @@ -1,13 +1,13 @@ | |||
| # Fluentd | |||
|
|
|||
| Loki has a [Fluentd](https://www.fluentd.org/) output plugin called | |||
| `fluent-plugin-grafana-loki` that enables shipping logs to a private Loki | |||
There was a problem hiding this comment.
https://rubygems.org/gems/fluent-plugin-grafana-loki
That's the correct.
There was a problem hiding this comment.
The reason behind is the fluent-plugin-loki gem has been taken by someone else.
cyriltovena
reviewed
May 22, 2020
| @@ -119,18 +119,20 @@ This plugin automatically adds a `fluentd_thread` label with the name of the buf | |||
|
|
|||
| ## Docker Image | |||
|
|
|||
| There is a Docker image `grafana/fluent-plugin-grafana-loki:master` which contains [default configuration files](https://github.com/grafana/loki/tree/master/fluentd/fluent-plugin-grafana-loki/docker/conf). By default, fluentd containers use the configurations but you can also specify your `fluentd.conf` with `FLUENTD_CONF` environment variable. | |||
| There is a Docker image `grafana/fluent-plugin-loki:master` which contains [default configuration files](https://github.com/grafana/loki/tree/master/fluentd/fluent-plugin-loki/docker/conf). By default, fluentd containers use the configurations but you can also specify your `fluentd.conf` with `FLUENTD_CONF` environment variable. | |||
There was a problem hiding this comment.
However this is correct :) now ! the docker image is grafana/fluent-plugin-loki:master
cyriltovena
approved these changes
May 22, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Updates documentation:
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Checklist