-
Notifications
You must be signed in to change notification settings - Fork 3.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace memberlist service in favor of cortex provided service #2224
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thank you!
@pstibrany I believe it's time to give documentation also some love regarding memberlist. I can add an example configuration with a reference to a headless k8s service. |
That's a great idea. We have some documentation in Cortex, but nothing in Loki. |
Codecov Report
@@ Coverage Diff @@
## master #2224 +/- ##
==========================================
- Coverage 62.09% 62.08% -0.01%
==========================================
Files 156 156
Lines 12531 12529 -2
==========================================
- Hits 7781 7779 -2
Misses 4143 4143
Partials 607 607
|
Hmm... i noticed that we don't expose the memberlist flags for loki. Maybe also a good time to do so. WDYT? |
Interesting, yes, we should do that. Thanks! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Keeping an eye on this, looks good so far.
3d03504
to
e9712e0
Compare
@pstibrany @cyriltovena PTAL with the added docs and examples |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice example. Thanks for all your work on this PR!
What this PR does / why we need it:
This PR addresses the wiring work needed to use the non-experimental version of memberlist as provided by: cortexproject/cortex#2638
Which issue(s) this PR fixes:
Special notes for your reviewer:
Checklist
cc @cyriltovena @pstibrany