Promtail: Loki Push API #2296
Merged
Promtail: Loki Push API #2296
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #2296 +/- ##
==========================================
+ Coverage 60.99% 61.26% +0.26%
==========================================
Files 158 158
Lines 12751 12799 +48
==========================================
+ Hits 7778 7841 +63
+ Misses 4390 4364 -26
- Partials 583 594 +11
|
slim-bean
commented
Jul 3, 2020
| // Stop shuts down the PushTarget. | ||
| func (t *PushTarget) Stop() error { | ||
| level.Info(t.logger).Log("msg", "stopping push server", "job", t.jobName) | ||
| t.server.Shutdown() |
There was a problem hiding this comment.
Wanted to add a note, not sure here if it's worth having a waitgroup on the server thread and wait for it before returning here?
adityacs
reviewed
Jul 4, 2020
|
Now that Promtail acts as server for incoming logs, I think we should have a plan to handle Promtail crash. |
Co-authored-by: Owen Diehl <ow.diehl@gmail.com>
owen-d
approved these changes
Jul 8, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
This PR implements the Loki push API in promtail, allowing clients (including promtail) to send to another promtail instance which can then send to Loki (or even more promtails, infinite promtails!)
The original design for this was approved with #1627, this is the implementation of that design.
Which issue(s) this PR fixes:
Fixes #1576
Checklist