Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve documentation of the metric stage. #2335

Merged
merged 1 commit into from
Jul 10, 2020
Merged

Conversation

cyriltovena
Copy link
Contributor

Specially w/r/t max_idle_duration

see #2333

Specially w/r/t `max_idle_duration`
@codecov-commenter
Copy link

Codecov Report

Merging #2335 into master will increase coverage by 0.10%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2335      +/-   ##
==========================================
+ Coverage   61.28%   61.38%   +0.10%     
==========================================
  Files         158      158              
  Lines       12805    12805              
==========================================
+ Hits         7847     7860      +13     
+ Misses       4365     4350      -15     
- Partials      593      595       +2     
Impacted Files Coverage Δ
pkg/querier/queryrange/downstreamer.go 95.87% <0.00%> (-2.07%) ⬇️
pkg/promtail/positions/positions.go 60.71% <0.00%> (+13.39%) ⬆️

Copy link
Collaborator

@slim-bean slim-bean left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants