Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fluent bit docs #2390

Merged
merged 4 commits into from
Jul 23, 2020
Merged

Fluent bit docs #2390

merged 4 commits into from
Jul 23, 2020

Conversation

cyriltovena
Copy link
Contributor

Add fluentbit doc on the website and fixes some links.

Signed-off-by: Cyril Tovena <cyril.tovena@gmail.com>
Signed-off-by: Cyril Tovena <cyril.tovena@gmail.com>
Signed-off-by: Cyril Tovena <cyril.tovena@gmail.com>
Signed-off-by: Cyril Tovena <cyril.tovena@gmail.com>
@codecov-commenter
Copy link

Codecov Report

Merging #2390 into master will increase coverage by 0.03%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2390      +/-   ##
==========================================
+ Coverage   61.72%   61.76%   +0.03%     
==========================================
  Files         160      160              
  Lines       13577    13577              
==========================================
+ Hits         8381     8386       +5     
+ Misses       4569     4566       -3     
+ Partials      627      625       -2     
Impacted Files Coverage Δ
pkg/promtail/targets/file/filetarget.go 70.48% <0.00%> (+1.80%) ⬆️
pkg/promtail/targets/file/tailer.go 76.13% <0.00%> (+2.27%) ⬆️

Copy link
Member

@owen-d owen-d left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@owen-d owen-d merged commit 3d8688f into grafana:master Jul 23, 2020
cyriltovena pushed a commit to cyriltovena/loki that referenced this pull request Jun 11, 2021
…iately for filesystem type (grafana#2390)

* add support for more ObjectClient types and flush file immediately for filesystem type

Signed-off-by: Sandeep Sukhani <sandeep.d.sukhani@gmail.com>

* checking for error while closing file in FSObjectClient.PutObject

Signed-off-by: Sandeep Sukhani <sandeep.d.sukhani@gmail.com>

* changes suggested from PR review

Signed-off-by: Sandeep Sukhani <sandeep.d.sukhani@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants