Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More fixes for the website. #2402

Merged
merged 4 commits into from
Jul 24, 2020
Merged

Conversation

cyriltovena
Copy link
Contributor

Signed-off-by: Cyril Tovena cyril.tovena@gmail.com

Signed-off-by: Cyril Tovena <cyril.tovena@gmail.com>
@codecov-commenter
Copy link

codecov-commenter commented Jul 23, 2020

Codecov Report

Merging #2402 into doc-fixes will decrease coverage by 0.12%.
The diff coverage is n/a.

Impacted file tree graph

@@              Coverage Diff              @@
##           doc-fixes    #2402      +/-   ##
=============================================
- Coverage      61.72%   61.60%   -0.13%     
=============================================
  Files            160      160              
  Lines          13577    13577              
=============================================
- Hits            8381     8364      -17     
- Misses          4569     4587      +18     
+ Partials         627      626       -1     
Impacted Files Coverage Δ
pkg/promtail/positions/positions.go 47.32% <0.00%> (-13.40%) ⬇️
pkg/logql/evaluator.go 92.47% <0.00%> (-0.41%) ⬇️

Signed-off-by: Cyril Tovena <cyril.tovena@gmail.com>
Signed-off-by: Cyril Tovena <cyril.tovena@gmail.com>
Copy link
Member

@owen-d owen-d left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@owen-d
Copy link
Member

owen-d commented Jul 23, 2020

@cyriltovena small conflict here

@cyriltovena cyriltovena merged commit a28af34 into grafana:doc-fixes Jul 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants