Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Promtail: Allow empty replace values for replace stage #2432

Merged
merged 1 commit into from
Jul 28, 2020
Merged

Promtail: Allow empty replace values for replace stage #2432

merged 1 commit into from
Jul 28, 2020

Conversation

pyr0hu
Copy link
Contributor

@pyr0hu pyr0hu commented Jul 28, 2020

What this PR does / why we need it:
Allow empty replace value in replace stage to enable users to remove part of the log lines with regexes.

Which issue(s) this PR fixes:
Fixes #2033

Checklist

  • Documentation added
  • Tests updated

@CLAassistant
Copy link

CLAassistant commented Jul 28, 2020

CLA assistant check
All committers have signed the CLA.

@codecov-commenter
Copy link

Codecov Report

Merging #2432 into master will decrease coverage by 0.00%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2432      +/-   ##
==========================================
- Coverage   61.55%   61.55%   -0.01%     
==========================================
  Files         160      160              
  Lines       13612    13610       -2     
==========================================
- Hits         8379     8377       -2     
- Misses       4607     4608       +1     
+ Partials      626      625       -1     
Impacted Files Coverage Δ
pkg/logentry/stages/replace.go 62.00% <ø> (-0.75%) ⬇️
pkg/querier/queryrange/downstreamer.go 95.87% <0.00%> (-2.07%) ⬇️
pkg/logql/evaluator.go 92.88% <0.00%> (+0.40%) ⬆️

Copy link
Contributor

@cyriltovena cyriltovena left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cyriltovena cyriltovena merged commit 8301745 into grafana:master Jul 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Replace pipeline stage
4 participants