Create CODEOWNERS #2454
Merged
Create CODEOWNERS #2454
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #2454 +/- ##
==========================================
+ Coverage 62.79% 62.93% +0.13%
==========================================
Files 162 162
Lines 13963 13963
==========================================
+ Hits 8768 8787 +19
+ Misses 4513 4493 -20
- Partials 682 683 +1
|
cyriltovena
pushed a commit
to cyriltovena/loki
that referenced
this pull request
Jun 11, 2021
* allow 1w and 1y for -store.* Signed-off-by: Wing924 <weihe924stephen@gmail.com> * fix Signed-off-by: Wing924 <weihe924stephen@gmail.com>
kavirajk
added a commit
that referenced
this pull request
Aug 11, 2023
This file was added by docs squad some time back #2454 It's no longer needed as we have root level CODEOWNERS that has right permissions to docs squad already. If we need to change anything, we do it here Signed-off-by: Kaviraj <kavirajkanagaraj@gmail.com>
1 task
kavirajk
added a commit
that referenced
this pull request
Aug 11, 2023
**What this PR does / why we need it**: This file was added by docs squad some time back #2454 It's no longer needed as we have [root level CODEOWNERS](https://github.com/grafana/loki/blob/main/CODEOWNERS) that has right permissions to docs squad already. If we need to change anything, we do it here **Which issue(s) this PR fixes**: Fixes #<issue number> **Special notes for your reviewer**: **Checklist** - [x] Reviewed the [`CONTRIBUTING.md`](https://github.com/grafana/loki/blob/main/CONTRIBUTING.md) guide (**required**) Signed-off-by: Kaviraj <kavirajkanagaraj@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Makes me a codeowner of the Loki docs folder so that I have more visibility of what is going on with Loki docs and can assist with editing and advice.
This change only adds me as a reviewer to PRs that touch the docs folder. It does not require my approval for merging content into the docs folder, so it will not block any work.