Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the link error of the installation document #2524

Closed
wants to merge 1 commit into from
Closed

Fix the link error of the installation document #2524

wants to merge 1 commit into from

Conversation

wuzhihui1123
Copy link

Fix the link error of the installation document

Fix the link error of the installation document
@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

@codecov-commenter
Copy link

Codecov Report

Merging #2524 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #2524   +/-   ##
=======================================
  Coverage   63.56%   63.56%           
=======================================
  Files         163      163           
  Lines       14305    14305           
=======================================
  Hits         9093     9093           
- Misses       4499     4500    +1     
+ Partials      713      712    -1     
Impacted Files Coverage Δ
pkg/querier/queryrange/downstreamer.go 95.87% <0.00%> (-2.07%) ⬇️
pkg/logql/evaluator.go 92.88% <0.00%> (+0.40%) ⬆️

Copy link
Contributor

@sandeepsukhani sandeepsukhani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix! I have suggested just a nit otherwise it is good to go.

- [Install through Docker or Docker Compose](docker/)
- [Install and run locally](local/)
- [Install from source](install-from-source/)
- [Install using Tanka (recommended)](tanka.md/)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think the "/" needs to stay. Same for the lines below.
Can you please remove them as well while you are at it?

@sandeepsukhani
Copy link
Contributor

This looks like a duplicate of #2521 . Thanks for the PR!
Closing this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants