-
Notifications
You must be signed in to change notification settings - Fork 3.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(ksonnet): don't depend on specific k8s version #2525
Conversation
Codecov Report
@@ Coverage Diff @@
## master #2525 +/- ##
==========================================
+ Coverage 63.56% 63.59% +0.02%
==========================================
Files 163 163
Lines 14305 14305
==========================================
+ Hits 9093 9097 +4
+ Misses 4499 4497 -2
+ Partials 713 711 -2
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I unfortunately think removing this breaks functionality for end users. Can you try installing from a fresh tanka according to the docs? I think this stems from the changes in https://github.com/grafana/loki/pull/2460/files which don't play nicely with the default versions used by tanka, but which we override internally. We'll also need to update the blurb in our docs (the prior deploying link), but I think this is important to sort out. Thanks for looking into it @Duologic
Completely right, @owen-d. I've updated the docs accordingly. We are actively working to get k8s-alpha to GA. |
b6a296a
to
647a1a5
Compare
Removed docs and added compatibility for envVar. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great, thanks!
What this PR does / why we need it:
Loki should not depend on a specific k8s version (1.14), this would make upgrading clusters much harder.
As no imports are happening directly in this library, this change should be a no-op.