Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix dir setup based on which mode it is running #2559

Merged
merged 1 commit into from
Aug 27, 2020

Conversation

sandeepsukhani
Copy link
Contributor

What this PR does / why we need it:
When boltdb-shipper runs in a querier we will have only CacheLocation set while for ingester we will have only ActiveIndexDirectory set. Based on that expectation fixing the code which sets up the directories for them.

@codecov-commenter
Copy link

Codecov Report

Merging #2559 into master will decrease coverage by 0.01%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2559      +/-   ##
==========================================
- Coverage   62.85%   62.83%   -0.02%     
==========================================
  Files         169      169              
  Lines       14910    14911       +1     
==========================================
- Hits         9372     9370       -2     
- Misses       4790     4792       +2     
- Partials      748      749       +1     
Impacted Files Coverage Δ
pkg/storage/stores/shipper/shipper_index_client.go 0.00% <0.00%> (ø)
pkg/logql/evaluator.go 92.47% <0.00%> (-0.41%) ⬇️

Copy link
Collaborator

@slim-bean slim-bean left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sandeepsukhani sandeepsukhani merged commit 0a0ad68 into grafana:master Aug 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants