Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Read, Write and operational dashboard improvements #2584

Merged

Conversation

sandeepsukhani
Copy link
Contributor

@sandeepsukhani sandeepsukhani commented Sep 1, 2020

What this PR does / why we need it:

It does the following improvements to the dashboards to debug latency issues in index read/writes:

  • Add bigtable, boltdb-shipper to read/write dashboards.
  • Add boltdb-shipper to operational dashboard.
  • Record latency for write operation in boltdb-shipper.

1. Add bigtable, boltdb-shipper to read/write dashboards.
2. Add boltdb-shipper to operational dashboard.
3. Record latency for write operation in boltdb-shipper.
@codecov-commenter
Copy link

Codecov Report

Merging #2584 into master will decrease coverage by 0.02%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2584      +/-   ##
==========================================
- Coverage   63.01%   62.99%   -0.03%     
==========================================
  Files         169      169              
  Lines       15005    15007       +2     
==========================================
- Hits         9456     9454       -2     
- Misses       4796     4798       +2     
- Partials      753      755       +2     
Impacted Files Coverage Δ
pkg/storage/stores/shipper/shipper_index_client.go 0.00% <0.00%> (ø)
pkg/promtail/targets/file/filetarget.go 66.85% <0.00%> (-2.29%) ⬇️
pkg/querier/queryrange/downstreamer.go 97.93% <0.00%> (+2.06%) ⬆️

Copy link
Collaborator

@slim-bean slim-bean left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sandeepsukhani sandeepsukhani merged commit 6dd2e9e into grafana:master Sep 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants