fixes ruler docs & includes ruler configs in cmd/configs + docker img #2657
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
owen-d
requested review from
achatterjee-grafana and
oddlittlebird
as code owners
oddlittlebird
approved these changes
Sep 22, 2020
|
|
||
| _For more information, please check out the Prometheus [rules](https://prometheus.io/docs/prometheus/latest/querying/api/#rules) documentation._ | ||
|
|
||
| _This experimental endpoint is disabled by default and can be enabled via the `-experimental.ruler.enable-api` CLI flag (or its respective YAML config option)._ |
There was a problem hiding this comment.
Seems like you should lead with this. "It doesn't work unless you do this specific thing" is kind of important.
Codecov Report
@@ Coverage Diff @@
## master #2657 +/- ##
==========================================
- Coverage 61.29% 61.25% -0.04%
==========================================
Files 172 172
Lines 13360 13360
==========================================
- Hits 8189 8184 -5
- Misses 4419 4429 +10
+ Partials 752 747 -5
|
Co-authored-by: Diana Payton <52059945+oddlittlebird@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A few doc updates and adds some ruler configs to the docker image & configs under
cmd/loki