removes r/w pools from block/chunk types #2711
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #2711 +/- ##
==========================================
- Coverage 61.41% 61.35% -0.06%
==========================================
Files 173 173
Lines 13444 13439 -5
==========================================
- Hits 8257 8246 -11
- Misses 4430 4440 +10
+ Partials 757 753 -4
|
cyriltovena
approved these changes
Oct 1, 2020
cyriltovena
pushed a commit
to cyriltovena/loki
that referenced
this pull request
Oct 21, 2020
Signed-off-by: Cyril Tovena <cyril.tovena@gmail.com>
cyriltovena
pushed a commit
to cyriltovena/loki
that referenced
this pull request
Jun 11, 2021
…r a user (grafana#2711) * load delete requests frequently if there are more pending requests for a user Signed-off-by: Sandeep Sukhani <sandeep.d.sukhani@gmail.com> * fix an issue with a minor nit Signed-off-by: Sandeep Sukhani <sandeep.d.sukhani@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR lays some groundwork for the upcoming WAL work by disassociating reader/writer pools from memchunk & block types. These can be easily inferred and this should help reduce some complexity/make it easier to implement data-only types which can be more safely/effectively loaded to/from disk via
[]byte.