Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Doc: fixing parameter name in configuration #2716

Merged
merged 1 commit into from
Oct 5, 2020

Conversation

huikang
Copy link
Contributor

@huikang huikang commented Oct 3, 2020

  • http_path_prefix should be http_prefix

Signed-off-by: Hui Kang kangh@us.ibm.com

- http_path_prefix should be http_prefix

Signed-off-by: Hui Kang <kangh@us.ibm.com>
@codecov-commenter
Copy link

Codecov Report

Merging #2716 into master will decrease coverage by 0.08%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2716      +/-   ##
==========================================
- Coverage   61.40%   61.32%   -0.09%     
==========================================
  Files         173      173              
  Lines       13446    13446              
==========================================
- Hits         8257     8246      -11     
- Misses       4431     4444      +13     
+ Partials      758      756       -2     
Impacted Files Coverage Δ
pkg/promtail/positions/positions.go 46.80% <0.00%> (-11.71%) ⬇️

Copy link
Contributor

@achatterjee-grafana achatterjee-grafana left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thank you for your contribution.

@cyriltovena cyriltovena merged commit b9e8ddb into grafana:master Oct 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants