Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

better tenant logging in ruler memstore #2741

Merged
merged 1 commit into from
Oct 12, 2020

Conversation

owen-d
Copy link
Member

@owen-d owen-d commented Oct 8, 2020

Small fix that has more idiomatic field injection.

@codecov-io
Copy link

Codecov Report

Merging #2741 into master will decrease coverage by 0.00%.
The diff coverage is 66.66%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2741      +/-   ##
==========================================
- Coverage   61.39%   61.38%   -0.01%     
==========================================
  Files         173      173              
  Lines       13465    13465              
==========================================
- Hits         8267     8266       -1     
- Misses       4445     4446       +1     
  Partials      753      753              
Impacted Files Coverage Δ
pkg/ruler/manager/memstore.go 68.29% <66.66%> (ø)
pkg/promtail/targets/file/tailer.go 70.09% <0.00%> (-5.61%) ⬇️
pkg/logql/evaluator.go 92.81% <0.00%> (+0.42%) ⬆️
pkg/promtail/targets/file/filetarget.go 66.19% <0.00%> (+2.11%) ⬆️

Copy link
Contributor

@cyriltovena cyriltovena left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@owen-d owen-d merged commit 6b17831 into grafana:master Oct 12, 2020
cyriltovena pushed a commit to cyriltovena/loki that referenced this pull request Oct 21, 2020
Signed-off-by: Cyril Tovena <cyril.tovena@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants