-
Notifications
You must be signed in to change notification settings - Fork 3.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Revendor cortex to latest master #2794
Revendor cortex to latest master #2794
Conversation
eb11366
to
67ff032
Compare
Codecov Report
@@ Coverage Diff @@
## master #2794 +/- ##
==========================================
- Coverage 61.39% 61.32% -0.08%
==========================================
Files 177 178 +1
Lines 14394 14419 +25
==========================================
+ Hits 8837 8842 +5
- Misses 4748 4763 +15
- Partials 809 814 +5
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm. We've called these proto add-on methods extensions.go
before (https://github.com/grafana/loki/blob/master/pkg/logproto/extensions.go) if you'd like to keep this consistent.
Sounds good. Renamed it. |
What this PR does / why we need it:
There are some fixes in object client in Cortex which would be good to have for avoiding any problems running
boltdb-shipper
.I have taken care of some of the changes done in Cortex, most important ones are at https://github.com/grafana/loki/blob/d580aa9da860d5bceee606cc5420c8eb20b275aa/pkg/querier/queryrange/queryrange.pb.patch.go
Checklist