Documentation: Add S3 IAM policy to be able to run Compactor #2817
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
scoof
requested review from
achatterjee-grafana and
oddlittlebird
as code owners
|
|
Codecov Report
@@ Coverage Diff @@
## master #2817 +/- ##
=======================================
Coverage 61.30% 61.30%
=======================================
Files 179 179
Lines 14438 14438
=======================================
Hits 8851 8851
- Misses 4775 4779 +4
+ Partials 812 808 -4
|
slim-bean
reviewed
Oct 27, 2020
| @@ -51,6 +51,7 @@ When using S3 as object storage, the following permissions are needed: | |||
| - `s3:ListBucket` | |||
| - `s3:PutObject` | |||
| - `s3:GetObject` | |||
| - `s3:DeleteObject` (if running the compactor) | |||
There was a problem hiding this comment.
Suggested change
| - `s3:DeleteObject` (if running the compactor) | |
| - `s3:DeleteObject` (if running the Single Store (boltdb-shipper) compactor) |
There was a problem hiding this comment.
ha @owen-d was quick on the trigger. Thanks for this it looks good!
cyriltovena
pushed a commit
to cyriltovena/loki
that referenced
this pull request
Jun 11, 2021
* fix a race in purger managing in process delete requests Signed-off-by: Sandeep Sukhani <sandeep.d.sukhani@gmail.com> * update changelog Signed-off-by: Sandeep Sukhani <sandeep.d.sukhani@gmail.com> * fix a problem in taking address of delete requests in loops Signed-off-by: Sandeep Sukhani <sandeep.d.sukhani@gmail.com> * minor nit Signed-off-by: Sandeep Sukhani <sandeep.d.sukhani@gmail.com> * nit suggested in PR review Signed-off-by: Sandeep Sukhani <sandeep.d.sukhani@gmail.com> Co-authored-by: Marco Pracucci <marco@pracucci.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it: Updates docs to be able to run compactor on S3 storage