Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Iss2734 #2835

Merged
merged 2 commits into from
Nov 5, 2020
Merged

Iss2734 #2835

merged 2 commits into from
Nov 5, 2020

Conversation

tracyde
Copy link
Contributor

@tracyde tracyde commented Oct 28, 2020

What this PR does / why we need it:
Works around a helm issue (helm/helm#1707 (comment)) where a value that is meant to be an int gets cast to a float. In this case the fluent-bit helm chart BatchSize default value of 1048576 was being sent to the configmap in scientific notation 1.048576e+06.

Which issue(s) this PR fixes:
Fixes #2734

Special notes for your reviewer:

Checklist

  • [ n/a ] Documentation added
  • [ n/a ] Tests updated

@CLAassistant
Copy link

CLAassistant commented Oct 28, 2020

CLA assistant check
All committers have signed the CLA.

@codecov-io
Copy link

Codecov Report

Merging #2835 into master will decrease coverage by 0.09%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2835      +/-   ##
==========================================
- Coverage   61.37%   61.28%   -0.10%     
==========================================
  Files         179      179              
  Lines       14438    14438              
==========================================
- Hits         8862     8848      -14     
- Misses       4766     4778      +12     
- Partials      810      812       +2     
Impacted Files Coverage Δ
pkg/promtail/positions/positions.go 46.80% <0.00%> (-11.71%) ⬇️
pkg/promtail/targets/file/filetarget.go 64.08% <0.00%> (-2.12%) ⬇️
pkg/storage/stores/shipper/uploads/table.go 68.66% <0.00%> (-1.85%) ⬇️
...kg/storage/stores/shipper/uploads/table_manager.go 65.78% <0.00%> (-1.76%) ⬇️
pkg/logql/evaluator.go 91.64% <0.00%> (+0.40%) ⬆️
pkg/canary/comparator/comparator.go 78.18% <0.00%> (+1.81%) ⬆️

Copy link
Contributor

@cyriltovena cyriltovena left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cyriltovena cyriltovena merged commit 2dec2d2 into grafana:master Nov 5, 2020
mraboosk pushed a commit to mraboosk/loki that referenced this pull request Oct 7, 2024
* force fluent-bit configmap BatchSize to be evaluated as an `int`

* update fluent-bit helm chart patch version
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Helm templating error for fluent-bit chart - BatchSize in fluent-bit configmap wrong
4 participants