Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update CODEOWNERS #2888

Merged
merged 1 commit into from
Nov 6, 2020
Merged

Update CODEOWNERS #2888

merged 1 commit into from
Nov 6, 2020

Conversation

oddlittlebird
Copy link
Contributor

What this PR does / why we need it: Minor update to clarify CODEOWNERS comments

Which issue(s) this PR fixes:
Fixes #

Special notes for your reviewer:

Checklist

  • Documentation added
  • Tests updated

@codecov-io
Copy link

Codecov Report

Merging #2888 into master will increase coverage by 0.06%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2888      +/-   ##
==========================================
+ Coverage   61.56%   61.62%   +0.06%     
==========================================
  Files         181      181              
  Lines       14675    14675              
==========================================
+ Hits         9034     9044      +10     
+ Misses       4819     4807      -12     
- Partials      822      824       +2     
Impacted Files Coverage Δ
pkg/promtail/targets/file/filetarget.go 64.08% <0.00%> (-2.12%) ⬇️
pkg/logql/evaluator.go 91.64% <0.00%> (+0.40%) ⬆️
pkg/promtail/positions/positions.go 58.51% <0.00%> (+11.70%) ⬆️

@oddlittlebird
Copy link
Contributor Author

Codecov, you're drunk. Go home.

Copy link
Contributor

@cyriltovena cyriltovena left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cyriltovena cyriltovena merged commit 8a3c9c8 into master Nov 6, 2020
@cyriltovena cyriltovena deleted the oddlittlebird-patch-1 branch November 6, 2020 07:08
cyriltovena pushed a commit to cyriltovena/loki that referenced this pull request Jun 11, 2021
Signed-off-by: Julien Pivotto <roidelapluie@inuits.eu>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants