Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Distributor registers logproto.Pusher service to receive logs via GRPC #2922

Merged
merged 1 commit into from
Nov 13, 2020
Merged

Distributor registers logproto.Pusher service to receive logs via GRPC #2922

merged 1 commit into from
Nov 13, 2020

Conversation

codewithcheese
Copy link
Contributor

@codewithcheese codewithcheese commented Nov 12, 2020

What this PR does / why we need it:
Distributor registers the logproto.Pusher service so that logs can be pushed to the distributor using GRPC. GRPC has a number of benefits over REST and this change would allow clients to push to the distributor using GRPC instead of REST.

Special notes for your reviewer:
See discussion: https://app.slack.com/client/T05675Y01/CEPJRLQNL/thread/CEPJRLQNL-1605100868.117200

Checklist

  • Documentation added
  • Tests updated

Resolves #2921

@CLAassistant
Copy link

CLAassistant commented Nov 12, 2020

CLA assistant check
All committers have signed the CLA.

@codecov-io
Copy link

Codecov Report

Merging #2922 (44f6500) into master (f0d4adc) will decrease coverage by 0.05%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2922      +/-   ##
==========================================
- Coverage   61.72%   61.67%   -0.06%     
==========================================
  Files         181      181              
  Lines       14724    14725       +1     
==========================================
- Hits         9089     9082       -7     
- Misses       4801     4812      +11     
+ Partials      834      831       -3     
Impacted Files Coverage Δ
pkg/loki/modules.go 3.47% <0.00%> (-0.02%) ⬇️
pkg/promtail/positions/positions.go 46.80% <0.00%> (-11.71%) ⬇️
pkg/logql/evaluator.go 91.64% <0.00%> (+0.40%) ⬆️
pkg/querier/queryrange/downstreamer.go 97.64% <0.00%> (+2.35%) ⬆️

Copy link
Contributor

@cyriltovena cyriltovena left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cyriltovena cyriltovena merged commit a5cc650 into grafana:master Nov 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Write logs to distributor via GRPC Error: 12 UNIMPLEMENTED: unknown service logproto.Pusher
4 participants