Only append tailed entries if needed. #2931
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This avoid to doing allocations on slices when there is no tailers. We could potentially pooled the slice too but the tailing code is using the stream in an async fashion so we can't put it back. Signed-off-by: Cyril Tovena <cyril.tovena@gmail.com>
owen-d
approved these changes
Nov 17, 2020
| } | ||
| } | ||
|
|
||
| type noopChunk struct { |
There was a problem hiding this comment.
Could we just expose dumbChunk instead from the chunkenc pkg?
There was a problem hiding this comment.
dumbchunk does allocation which makes some noise in the benchmark.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This avoid to doing allocations on slices when there is no tailers.
We could potentially pooled the slice too but the tailing code is using the stream in an
async fashion so we can't put it back.
Signed-off-by: Cyril Tovena cyril.tovena@gmail.com