Fixes the Stringer of the byte label operator. #2946
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This would cause the operator to become a numeric one once stringified. Signed-off-by: Cyril Tovena <cyril.tovena@gmail.com>
cyriltovena
force-pushed
the
fix-bytesop-string
branch
from
ed7c227
to
fa15aab
Compare
jeschkies
approved these changes
Nov 18, 2020
cyriltovena
pushed a commit
to cyriltovena/loki
that referenced
this pull request
Jun 11, 2021
* integration test for deletion of series Signed-off-by: Sandeep Sukhani <sandeep.d.sukhani@gmail.com> * update changelog Signed-off-by: Sandeep Sukhani <sandeep.d.sukhani@gmail.com> * Reuse existing timeout Signed-off-by: Marco Pracucci <marco@pracucci.com> * Removed Println() Signed-off-by: Marco Pracucci <marco@pracucci.com> * Assert on Purger metrics too Signed-off-by: Marco Pracucci <marco@pracucci.com> * Removed time.Sleep() from delete series integration test Signed-off-by: Marco Pracucci <marco@pracucci.com> * Moved CHANGELOG entry Signed-off-by: Marco Pracucci <marco@pracucci.com> Co-authored-by: Marco Pracucci <marco@pracucci.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This would cause the operator to become a numeric one once stringified.
Signed-off-by: Cyril Tovena cyril.tovena@gmail.com