Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Docs] Clarify docker-driver configuration options #3049

Merged
merged 1 commit into from
Dec 7, 2020
Merged

[Docs] Clarify docker-driver configuration options #3049

merged 1 commit into from
Dec 7, 2020

Conversation

vitalets
Copy link
Contributor

@vitalets vitalets commented Dec 7, 2020

Clarify docker-driver configuration about max-file and max-size default values.
Fixes #3046

Checklist

  • Documentation added
  • Tests updated

@vitalets
[Docs] Clarify docker-driver configuration options
1ddcc17 
Clarify docker-driver configuration about `max-file` and `max-size` default values.
Fixes grafana#3046
@CLAassistant
Copy link

CLAassistant commented Dec 7, 2020 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

cyriltovena
cyriltovena approved these changes Dec 7, 2020
View reviewed changes
Copy link
Contributor

@cyriltovena cyriltovena left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cyriltovena cyriltovena merged commit d05529f into grafana:master Dec 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cyriltovena cyriltovena cyriltovena approved these changes

Assignees
No one assigned
Labels
size/XS
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Does Loki docker driver respect max-file and max-size from json-driver?
3 participants
@vitalets @CLAassistant @cyriltovena