Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ksonnet: Assign appropriate pvc size and class to compactor and ingester #3074

Merged
merged 1 commit into from
Jan 4, 2021
Merged

Ksonnet: Assign appropriate pvc size and class to compactor and ingester #3074

merged 1 commit into from
Jan 4, 2021

Conversation

c0ffeec0der
Copy link
Contributor

What this PR does / why we need it:

Incorrect assignment of pvc size and class to compactor and ingester

Which issue(s) this PR fixes:
None

Special notes for your reviewer:

Checklist

  • Documentation added
  • Tests updated

@codecov-io
Copy link

Codecov Report

Merging #3074 (fa41875) into master (6c8ad52) will increase coverage by 0.03%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3074      +/-   ##
==========================================
+ Coverage   62.80%   62.83%   +0.03%     
==========================================
  Files         186      186              
  Lines       15949    15949              
==========================================
+ Hits        10017    10022       +5     
+ Misses       5005     4999       -6     
- Partials      927      928       +1     
Impacted Files Coverage Δ
pkg/logql/evaluator.go 89.87% <0.00%> (-0.36%) ⬇️
pkg/canary/comparator/comparator.go 78.18% <0.00%> (+1.81%) ⬆️
pkg/promtail/targets/file/filetarget.go 66.43% <0.00%> (+2.09%) ⬆️

@c0ffeec0der
Copy link
Contributor Author

@owen-d Hello,

Would you be able to approve this PR? This is just a minor fix to assign the appropriate pvc size and class to compactor and ingester. Thank you

Copy link
Contributor

@sandeepsukhani sandeepsukhani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR!
It LGTM.

@sandeepsukhani sandeepsukhani merged commit 03aaa34 into grafana:master Jan 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants