Improve tailer matching by using the index. #3090
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
``` ❯ benchcmp before.txt after benchmark old ns/op new ns/op delta Benchmark_instance_addNewTailer-16 537731 1479 -99.72% benchmark old allocs new allocs delta Benchmark_instance_addNewTailer-16 244 3 -98.77% benchmark old bytes new bytes delta Benchmark_instance_addNewTailer-16 22098 121 -99.45% ``` Signed-off-by: Cyril Tovena <cyril.tovena@gmail.com>
Codecov Report
@@ Coverage Diff @@
## master #3090 +/- ##
==========================================
+ Coverage 62.86% 62.91% +0.04%
==========================================
Files 186 186
Lines 15949 15951 +2
==========================================
+ Hits 10026 10035 +9
+ Misses 4996 4986 -10
- Partials 927 930 +3
|
pkg/ingester/tailer.go
Outdated
| return false | ||
| for _, l := range lbs { | ||
| for _, matcher := range t.matchers { | ||
| if l.Name == matcher.Name && !matcher.Matches(l.Value) { |
There was a problem hiding this comment.
This would work only if matchers has all the label names from lbs.
E.g if lbs is foo=bar, env=prod and matchers is app=bazz, it would return true because the condition here would be false for all the iterations and we return true at the end.
What do you think?
There was a problem hiding this comment.
Yep I'll add a test making sure we don't do this one again.
owen-d
requested changes
Jan 5, 2021
There was a problem hiding this comment.
I think @sandeepsukhani's suggestion needs to be addressed then LGTM
pkg/ingester/tailer.go
Outdated
| return false | ||
| for _, l := range lbs { | ||
| for _, matcher := range t.matchers { | ||
| if l.Name == matcher.Name && !matcher.Matches(l.Value) { |
Signed-off-by: Cyril Tovena <cyril.tovena@gmail.com>
owen-d
approved these changes
Jan 6, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Cyril Tovena cyril.tovena@gmail.com
What this PR does / why we need it:
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Checklist