Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Doc: Add missing wal in configuration #3162

Merged
merged 4 commits into from
Jan 19, 2021

Conversation

huikang
Copy link
Contributor

@huikang huikang commented Jan 12, 2021

What this PR does / why we need it:
WAL is missing in the configuration doc.

Which issue(s) this PR fixes:
Fixes #3157

Checklist

  • Documentation added

@codecov-io
Copy link

codecov-io commented Jan 12, 2021

Codecov Report

Merging #3162 (c576242) into master (1f6fd5e) will decrease coverage by 0.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3162      +/-   ##
==========================================
- Coverage   63.34%   63.32%   -0.02%     
==========================================
  Files         188      188              
  Lines       16304    16304              
==========================================
- Hits        10327    10325       -2     
- Misses       5036     5037       +1     
- Partials      941      942       +1     
Impacted Files Coverage Δ
pkg/ingester/transfer.go 60.14% <0.00%> (-1.45%) ⬇️

Copy link
Member

@owen-d owen-d left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few suggestion, then looks good.

Thanks for the doc fixes!

docs/sources/configuration/_index.md Outdated Show resolved Hide resolved
docs/sources/configuration/_index.md Outdated Show resolved Hide resolved
Hui Kang and others added 2 commits January 15, 2021 12:04
Co-authored-by: Owen Diehl <ow.diehl@gmail.com>
Co-authored-by: Owen Diehl <ow.diehl@gmail.com>
Copy link
Contributor

@sandeepsukhani sandeepsukhani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR.

@sandeepsukhani sandeepsukhani merged commit 1ffd4f6 into grafana:master Jan 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Missing document of wal for ingester configuration in doc
4 participants