Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc(gcplog): Fix titles for Cloud provisioning for GCP logs #3190

Merged
merged 1 commit into from
Jan 19, 2021
Merged

doc(gcplog): Fix titles for Cloud provisioning for GCP logs #3190

merged 1 commit into from
Jan 19, 2021

Conversation

kavirajk
Copy link
Contributor

What this PR does / why we need it:

Which issue(s) this PR fixes:
Document format fixes for GCP log

Special notes for your reviewer:

Checklist

  • Documentation added
  • Tests updated

@kavirajk kavirajk requested a review from a team January 19, 2021 11:46
@codecov-io
Copy link

Codecov Report

Merging #3190 (a0bb50a) into master (6cc41f9) will decrease coverage by 0.06%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3190      +/-   ##
==========================================
- Coverage   63.35%   63.28%   -0.07%     
==========================================
  Files         194      194              
  Lines       16535    16535              
==========================================
- Hits        10476    10465      -11     
- Misses       5108     5121      +13     
+ Partials      951      949       -2     
Impacted Files Coverage Δ
pkg/promtail/positions/positions.go 46.80% <0.00%> (-11.71%) ⬇️

@cyriltovena cyriltovena merged commit 3054d64 into grafana:master Jan 19, 2021
cyriltovena pushed a commit to cyriltovena/loki that referenced this pull request Jun 11, 2021
…3190)

* Turn memcached circuit-breaker on by default

Will trip after 10 failures within 10 seconds

Signed-off-by: Bryan Boreham <bjboreham@gmail.com>

* Change circuit-breaker log fields to avoid clash

The names 'from' and 'to' are used elsewhere as dates, so avoid re-using them here as strings

Signed-off-by: Bryan Boreham <bjboreham@gmail.com>

* Update CHANGELOG

Signed-off-by: Bryan Boreham <bjboreham@gmail.com>

* Updated doc

Signed-off-by: Marco Pracucci <marco@pracucci.com>

Co-authored-by: Marco Pracucci <marco@pracucci.com>

Co-authored-by: Bryan Boreham <bryan@weave.works>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants