Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Update docs for logcli #3212

Merged
merged 2 commits into from
Jan 22, 2021
Merged

Fix: Update docs for logcli #3212

merged 2 commits into from
Jan 22, 2021

Conversation

nvtkaszpir
Copy link
Contributor

What this PR does / why we need it:

Fix description for logcli, use proper flag names.
Extend docs with example using timestamp.

Which issue(s) this PR fixes:
Maybe not fixes but helps to acheive log download from loki described in #409

Special notes for your reviewer:
I tried to use command as described but there was an issue that:

  • there were unrecognized flags (--start and --end were replaced with --from and --to)
  • the timestamp message was pretty vague, apparetnly logcli appends timezone string, so the --from and --to are not exackly RFC3339Nano but more like RFC3339Nano without timezone.

Checklist

  • [v] Documentation added

Fix description for logcli, use proper flag names.
Extend docs with example using timestamp.

Signed-off-by: Michał Sochoń <kaszpir@gmail.com>
@CLAassistant
Copy link

CLAassistant commented Jan 21, 2021

CLA assistant check
All committers have signed the CLA.

Copy link
Member

@owen-d owen-d left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One small suggestion, but LGTM

cmd/logcli/main.go Outdated Show resolved Hide resolved
Co-authored-by: Owen Diehl <ow.diehl@gmail.com>
@owen-d
Copy link
Member

owen-d commented Jan 22, 2021

Thanks for the contribution!

@codecov-io
Copy link

Codecov Report

Merging #3212 (aa6a354) into master (e74eb54) will increase coverage by 0.04%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3212      +/-   ##
==========================================
+ Coverage   63.16%   63.21%   +0.04%     
==========================================
  Files         196      196              
  Lines       16668    16668              
==========================================
+ Hits        10529    10536       +7     
+ Misses       5187     5179       -8     
- Partials      952      953       +1     
Impacted Files Coverage Δ
pkg/canary/comparator/comparator.go 76.36% <0.00%> (-1.82%) ⬇️
pkg/promtail/positions/positions.go 58.51% <0.00%> (+11.70%) ⬆️

@owen-d owen-d merged commit 3bb7f52 into grafana:master Jan 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants