Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid putting all the GCP labels into loki labels #3284

Merged
merged 1 commit into from
Feb 3, 2021
Merged

Avoid putting all the GCP labels into loki labels #3284

merged 1 commit into from
Feb 3, 2021

Conversation

kavirajk
Copy link
Contributor

@kavirajk kavirajk commented Feb 3, 2021

What this PR does / why we need it:
Avoid putting all the lables coming from GCP into Loki

Which issue(s) this PR fixes:
NA

Special notes for your reviewer:
NA

Checklist

  • Documentation added
  • Tests updated

NOTE: Need to fix the dev dashboards after this merge.

@pull-request-size pull-request-size bot added size/S and removed size/XS labels Feb 3, 2021
@kavirajk kavirajk requested a review from a team February 3, 2021 10:27
Copy link
Collaborator

@slim-bean slim-bean left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@slim-bean slim-bean merged commit d667dd2 into grafana:master Feb 3, 2021
rfratto added a commit to rfratto/agent that referenced this pull request Feb 3, 2021
@rfratto rfratto mentioned this pull request Feb 3, 2021
3 tasks
@kavirajk kavirajk deleted the remove-gcp-labels branch February 3, 2021 13:31
rfratto added a commit to grafana/agent that referenced this pull request Feb 3, 2021
mattdurham pushed a commit to grafana/agent that referenced this pull request Nov 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants