chore: update cortex to latest and fix refs #3295
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jacob Lisi <jacob.t.lisi@gmail.com>
Signed-off-by: Jacob Lisi <jacob.t.lisi@gmail.com>
pracucci
approved these changes
Feb 4, 2021
There was a problem hiding this comment.
As Jacob mentioned, we did a couple of breaking changes in Cortex:
- Moved logger from
pkg/utiltopkg/util/log(just moved, no logic change) - Rename
ring.IngesterDesctoring.InstanceDesc(just renamed, no logic change)
I went through the diff and changes LGTM.
cyriltovena
pushed a commit
to cyriltovena/loki
that referenced
this pull request
Feb 15, 2021
* chore: update cortex to latest and fix refs Signed-off-by: Jacob Lisi <jacob.t.lisi@gmail.com> * tidy mod file Signed-off-by: Jacob Lisi <jacob.t.lisi@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
This PR updates to the latest version of Cortex and updates the reference for the global logger since the original Global Logger was removed.
The number of LOC changes is due to the global logger being used throughout the project. The changes should be noops.