Instrumentation: Add histogram for request duration on gRPC client to Ingesters #3409
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
gotjosh
force-pushed
the
instrument-grpc-to-ingesters
branch
from
0ecdcd2
to
f862314
Compare
… Ingesters Signed-off-by: gotjosh <josue@grafana.com>
gotjosh
force-pushed
the
instrument-grpc-to-ingesters
branch
from
f862314
to
5bd2bf4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
To provide more visibility on gRPC requests from distributor -> ingesters.
Which issue(s) this PR fixes:
N/A
Special notes for your reviewer:
The function from Cortex
grpcclient.Instrumentalready takes care of setting the tracing headers. It also accepts a histogram metric to record request durations. Hence, the replacement of the code below with the function - I made sure there was no difference between the function and the code removed.Checklist