Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modify script to accept inclusion and exclustion filters as variables #3422

Merged
merged 1 commit into from
Mar 3, 2021
Merged

Modify script to accept inclusion and exclustion filters as variables #3422

merged 1 commit into from
Mar 3, 2021

Conversation

kavirajk
Copy link
Contributor

@kavirajk kavirajk commented Mar 3, 2021

What this PR does / why we need it:
Support gcplog terraform script to accept inclusion and exclusion filter as variables.

Which issue(s) this PR fixes:
Fixes #
NA

Special notes for your reviewer:

Checklist

  • Documentation added
  • Tests updated

@kavirajk kavirajk requested a review from a team March 3, 2021 11:03
@codecov-io
Copy link

Codecov Report

Merging #3422 (28a25c6) into master (20ef66d) will decrease coverage by 0.05%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3422      +/-   ##
==========================================
- Coverage   63.01%   62.95%   -0.06%     
==========================================
  Files         205      205              
  Lines       17499    17499              
==========================================
- Hits        11027    11017      -10     
- Misses       5481     5494      +13     
+ Partials      991      988       -3     
Impacted Files Coverage Δ
pkg/promtail/positions/positions.go 46.80% <0.00%> (-11.71%) ⬇️
pkg/querier/queryrange/limits.go 86.91% <0.00%> (-1.87%) ⬇️
pkg/ingester/checkpoint.go 72.83% <0.00%> (-1.14%) ⬇️
pkg/promtail/targets/file/tailer.go 78.57% <0.00%> (+5.35%) ⬆️

@owen-d owen-d merged commit 071fd5b into grafana:master Mar 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants