support math functions in line_format and label_format #3434
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cyriltovena
reviewed
Mar 8, 2021
adityacs
commented
Mar 9, 2021
|
|
||
| ## add | ||
|
|
||
| > **Note:** Added in Loki 2.2. |
There was a problem hiding this comment.
Not sure if this should be 2.2. We may have to change.
There was a problem hiding this comment.
Yeah this is going to be 2.3
Signed-off-by: Cyril Tovena <cyril.tovena@gmail.com>
cyriltovena
force-pushed
the
line_format_math_functions
branch
from
dc55ea8
to
d752bc0
Compare
cyriltovena
added a commit
to cyriltovena/loki
that referenced
this pull request
Mar 19, 2021
Signed-off-by: Cyril Tovena <cyril.tovena@gmail.com>
cyriltovena
added a commit
that referenced
this pull request
Mar 19, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Add math functions to line_format and label_format.
Which issue(s) this PR fixes:
Fixes #2847, Fixes #2955
Checklist