Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support labelallow stage in Promtail #3468

Merged
merged 5 commits into from
Mar 17, 2021
Merged

Conversation

adityacs
Copy link
Contributor

What this PR does / why we need it:
Support labelallow stage in Promtail

Checklist

  • Documentation added
  • Tests updated

@adityacs adityacs requested a review from slim-bean March 10, 2021 13:59
@adityacs adityacs changed the title Labeladd Labelallow Mar 10, 2021
@adityacs adityacs changed the title Labelallow Support labelallow stage in Promtail Mar 10, 2021
Comment on lines +31 to +36
Given the following incoming labels:
- `kubernetes_pod_name`: `"loki-pqrs"`
- `kubernetes_container_name`: `"loki"`
- `kubernetes_pod_template_hash`: `"79f5db67b"`
- `kubernetes_controller_revision_hash`: `"774858987d"`
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need a better example?

Copy link
Collaborator

@slim-bean slim-bean left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @adityacs this is great! could you also update the doc page which lists all the stages the _index.md file in the stages folder?

@adityacs
Copy link
Contributor Author

@slim-bean Updated _index.md

Copy link
Collaborator

@slim-bean slim-bean left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@slim-bean slim-bean merged commit 0f5fcee into grafana:master Mar 17, 2021
slim-bean pushed a commit that referenced this pull request Apr 6, 2021
* add labelallow stage

* added docs

* add docs

* fix lint

* update stage name in _index.md

(cherry picked from commit 0f5fcee)
@slim-bean slim-bean mentioned this pull request Apr 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants