Fix documentation for memberlist to match code #3505
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The configuration block is a top level item as seen in 'Almost zero dependencies' setup in loki/docs/sources/configuration/examples.md
|
|
2 tasks
|
This was fixed in #3542 (my pull request was ignored) |
cyriltovena
added a commit
to cyriltovena/loki
that referenced
this pull request
Jun 11, 2021
It seems that some client might not returns those properties. see grafana#2912 Signed-off-by: Cyril Tovena <cyril.tovena@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
The documentation for
memberlistconfig is incorrect and prevents loki running if followed.memberlistitem is a top level item, as seen in Almost zero dependencies setup and in the code:loki/pkg/loki/loki.go
Line 72 in 835f710
Which issue(s) this PR fixes:
Partial fix of #3498