ignore download of missing boltdb files possibly removed during compaction #3563
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
This issue has been automatically marked as stale because it has not had any activity in the past 30 days. It will be closed in 7 days if no further activity occurs. Thank you for your contributions. |
sandeepsukhani
added
the
keepalive
stale
bot
removed
the
stale
sandeepsukhani
force-pushed
the
boltdb-shipper-ignore-missing-object-download-failure
branch
from
769dc8e
to
6e70fa4
Compare
sandeepsukhani
added a commit
that referenced
this pull request
Jun 10, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
We fail the sync operation when we encounter an error while downloading any of the files from the tables. When a file goes missing we fail the sync and retry it next time. A file only goes missing when it gets compacted away by the compactor so we do not want to fail the sync when a file goes missing in the middle of the sync operation.
Checklist