Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

replace time.Duration -> model.Duration for Limits. #3632

Merged
merged 1 commit into from
Apr 21, 2021
Merged

replace time.Duration -> model.Duration for Limits. #3632

merged 1 commit into from
Apr 21, 2021

Conversation

kavirajk
Copy link
Contributor

What this PR does / why we need it:
Rationale

  1. support user-friendly duration format (e.g: "1h30m45s") in JSON value.
  2. In consistent with Cortex and tempo.

Which issue(s) this PR fixes:
Fixes NA

Special notes for your reviewer:

Checklist

  • Documentation added
  • Tests updated

@CLAassistant
Copy link

CLAassistant commented Apr 21, 2021 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@kavirajk kavirajk requested a review from a team April 21, 2021 08:54
@kavirajk
replace time.Duration -> model.Duration for Limits.
cb7adf8 
Rationale
1. support user-friendly duration format (e.g: "1h30m45s") in JSON value.
2. In consistent with Cortex and tempo.
sandeepsukhani
sandeepsukhani approved these changes Apr 21, 2021
View reviewed changes
Copy link
Contributor

@sandeepsukhani sandeepsukhani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sandeepsukhani sandeepsukhani merged commit 6bcd980 into grafana:main Apr 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sandeepsukhani sandeepsukhani sandeepsukhani approved these changes

Assignees
No one assigned
Labels
size/L
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kavirajk @CLAassistant @sandeepsukhani