Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Doc update: updated label topic, specifically the example #3640

Closed
wants to merge 2 commits into from

Conversation

achatterjee-grafana
Copy link
Contributor

Based on feedback from the community. Verified with @owen-d.

@CLAassistant
Copy link

CLAassistant commented Apr 22, 2021

CLA assistant check
All committers have signed the CLA.

Copy link
Contributor

@oddlittlebird oddlittlebird left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@achatterjee-grafana achatterjee-grafana changed the title update the job_name to be something that doesn’t collide Doc update: updated label topic, specifically the example Apr 22, 2021
Copy link
Member

@owen-d owen-d left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should just change the job name here to not conflict in the following example, not add a new clause to this one.

scrape_configs:
 - job_name: system
   pipeline_stages:
   static_configs:
   - targets:
      - localhost
     labels:
      job: syslog
      __path__: /var/log/syslog
 - job_name: system <-------------- change to "apache" or similar
   pipeline_stages:
   static_configs:
   - targets:
      - localhost
     labels:
      job: apache
      __path__: /var/log/apache.log

I'd suggest "apache" as the new job name

Copy link
Member

@owen-d owen-d left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oops, looked like the second commit just updated the new lines the first commit added, not the actual line which needed to be changed and is already present in the docs.

@owen-d
Copy link
Member

owen-d commented Apr 22, 2021

This is the fix needed - feel free to adapt this PR if you'd like commit credit or we can merge that one: #3641

@owen-d owen-d closed this Apr 22, 2021
@achatterjee-grafana achatterjee-grafana deleted the Issue-3639 branch April 22, 2021 17:24
cyriltovena pushed a commit to cyriltovena/loki that referenced this pull request Jun 11, 2021
Signed-off-by: Christian Simon <simon@swine.de>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants