-
Notifications
You must be signed in to change notification settings - Fork 3.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Doc update: updated label topic, specifically the example #3640
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should just change the job name here to not conflict in the following example, not add a new clause to this one.
scrape_configs:
- job_name: system
pipeline_stages:
static_configs:
- targets:
- localhost
labels:
job: syslog
__path__: /var/log/syslog
- job_name: system <-------------- change to "apache" or similar
pipeline_stages:
static_configs:
- targets:
- localhost
labels:
job: apache
__path__: /var/log/apache.log
I'd suggest "apache" as the new job name
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oops, looked like the second commit just updated the new lines the first commit added, not the actual line which needed to be changed and is already present in the docs.
This is the fix needed - feel free to adapt this PR if you'd like commit credit or we can merge that one: #3641 |
Signed-off-by: Christian Simon <simon@swine.de>
Based on feedback from the community. Verified with @owen-d.