Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

correct logcli instant query timestamp param name #3739

Merged

Conversation

rsteneteg
Copy link
Contributor

Signed-off-by: Roger Steneteg rsteneteg@ea.com

What this PR does / why we need it:
It allows user to run instant queries in LogCLI with a start time in the past

Which issue(s) this PR fixes:
Fixes #3738

Special notes for your reviewer:

Checklist

  • Documentation added
  • Tests updated

Signed-off-by: Roger Steneteg <rsteneteg@ea.com>
@rsteneteg rsteneteg force-pushed the rsteneteg/logcli-instantquery-start branch from c4cefe1 to 38e1cab Compare May 17, 2021 19:44
Copy link
Contributor

@cyriltovena cyriltovena left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Nice catch.

@cyriltovena cyriltovena merged commit 0679e50 into grafana:main May 18, 2021
@rsteneteg rsteneteg deleted the rsteneteg/logcli-instantquery-start branch May 18, 2021 15:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

LogCLI instant queries always starts from now
2 participants