Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Danny Kopping danny.kopping@grafana.com
What this PR does / why we need it:
Allows for multiple targets to be defined. A "target" is a module inside Loki (querier, ingester, etc), and currently we can only target a single one. If no
-target
argument is provided, all modules are loaded, so there should be no reason to not allow multiple targets (i.e. a subset of modules) to be defined.Which issue(s) this PR fixes:
Fixes #3801
Special notes for your reviewer:
Cortex already implements this; I stole the implementation wholesale.
I also tried for a good couple hours to write tests for this, but unfortunately it's made rather difficult since a lot of the fields and functions in this package are unexported. However, Cortex does test this package well so I'm confident in the implementation.
I don't think the documentation needs updating, but I have modified the flag description.
Checklist