Update the docker-driver doc about default labels #3814
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add more information on `container_name` default label and when it will be added to log line.
cyriltovena
requested changes
Jun 7, 2021
rgl
reviewed
Jun 7, 2021
|
I think the documentation should also mention how can we modify each label. That is, whether we have to use |
Co-authored-by: Rui Lopes <rgl@ruilopes.com>
cyriltovena
approved these changes
Jun 7, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add more information on
container_namedefault label and when it will be added to log line.What this PR does / why we need it:
Makes the docker-driver docs bit clear about
container_namedefault labelWhich issue(s) this PR fixes:
Fixes #3811 #3811
Special notes for your reviewer:
Checklist