Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Development Docker Compose Setup #3941

Merged
merged 6 commits into from
Jul 8, 2021

Conversation

cyriltovena
Copy link
Contributor

This PR adds a new dev setup that allows you to run the full distributed mode locally on docker-compose.
What's interesting about it, is that it runs the current code base by compiling it and build it with debug symbol for remote debugging.

See the README for the usage.

/cc @owen-d @dannykopping Feel free to add more to it like alerting and ruling.

Copy link
Contributor

@jeschkies jeschkies left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is pretty cool!

Please excuse my ignorance but not go with k3d or kind with Tanka? We've actually migrated the Integrations API from Docker Compose to k3d + Tanka (https://github.com/grafana/cloud-onboarding/tree/main/ops). I do like Docker Compose quite a bit but Tanka allowed us to reuse the same definitions from grafana/deployment_tools locally.

k3d also gives us nice endpoints such as grafana.k3d.localhost:9999.

tools/dev/loki-boltdb-storage-s3/README.md Outdated Show resolved Hide resolved
tools/dev/loki-boltdb-storage-s3/README.md Show resolved Hide resolved
mkdir ${SRC_DEST}
for d in cmd pkg vendor clients
do
cp -Rf ${SCRIPT_DIR}/../../../${d}/ ${SRC_DEST}/${d}/
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are we running shellcheck on the Loki repo? I think variables in paths should be in quotes if I'm not mistaken.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not a bash fu so I trust you, I'll rebase to your PR.

@cyriltovena
Copy link
Contributor Author

This is pretty cool!

Please excuse my ignorance but not go with k3d or kind with Tanka? We've actually migrated the Integrations API from Docker Compose to k3d + Tanka (https://github.com/grafana/cloud-onboarding/tree/main/ops). I do like Docker Compose quite a bit but Tanka allowed us to reuse the same definitions from grafana/deployment_tools locally.

k3d also gives us nice endpoints such as grafana.k3d.localhost:9999.

I didn't wanted to add the complexity of having to setup tanka or k8s, just plain docker ! However this not exclusive we could have another folder that does that too.

cyriltovena and others added 6 commits July 6, 2021 11:51
Signed-off-by: Cyril Tovena <cyril.tovena@gmail.com>
Signed-off-by: Cyril Tovena <cyril.tovena@gmail.com>
Signed-off-by: Cyril Tovena <cyril.tovena@gmail.com>
Signed-off-by: Cyril Tovena <cyril.tovena@gmail.com>
Co-authored-by: Karsten Jeschkies <k@jeschkies.xyz>
Signed-off-by: Cyril Tovena <cyril.tovena@gmail.com>
Copy link
Member

@owen-d owen-d left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool work - I'm sure this was a pain to setup. Thanks :)

@cyriltovena cyriltovena merged commit 86000dd into grafana:main Jul 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants