-
Notifications
You must be signed in to change notification settings - Fork 3.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Development Docker Compose Setup #3941
Development Docker Compose Setup #3941
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is pretty cool!
Please excuse my ignorance but not go with k3d or kind with Tanka? We've actually migrated the Integrations API from Docker Compose to k3d + Tanka (https://github.com/grafana/cloud-onboarding/tree/main/ops). I do like Docker Compose quite a bit but Tanka allowed us to reuse the same definitions from grafana/deployment_tools locally.
k3d also gives us nice endpoints such as grafana.k3d.localhost:9999
.
mkdir ${SRC_DEST} | ||
for d in cmd pkg vendor clients | ||
do | ||
cp -Rf ${SCRIPT_DIR}/../../../${d}/ ${SRC_DEST}/${d}/ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are we running shellcheck on the Loki repo? I think variables in paths should be in quotes if I'm not mistaken.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not a bash fu so I trust you, I'll rebase to your PR.
I didn't wanted to add the complexity of having to setup tanka or k8s, just plain docker ! However this not exclusive we could have another folder that does that too. |
Signed-off-by: Cyril Tovena <cyril.tovena@gmail.com>
Signed-off-by: Cyril Tovena <cyril.tovena@gmail.com>
Signed-off-by: Cyril Tovena <cyril.tovena@gmail.com>
Signed-off-by: Cyril Tovena <cyril.tovena@gmail.com>
Co-authored-by: Karsten Jeschkies <k@jeschkies.xyz>
Signed-off-by: Cyril Tovena <cyril.tovena@gmail.com>
eee3a94
to
0c8aca4
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Cool work - I'm sure this was a pain to setup. Thanks :)
This PR adds a new dev setup that allows you to run the full distributed mode locally on docker-compose.
What's interesting about it, is that it runs the current code base by compiling it and build it with debug symbol for remote debugging.
See the README for the usage.
/cc @owen-d @dannykopping Feel free to add more to it like alerting and ruling.