Docs: added new target (docs-next) to the docs' Makefile. #3962
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This target builds local docs as they should look for commits that are placed into the main branch, showing the next up, but not yet released Loki docs.
jeschkies
reviewed
Jul 8, 2021
| .PHONY: docs-next | ||
| docs-next: | ||
| docker pull ${IMAGE} | ||
| docker run --rm -it -v ${PWD}/sources:/hugo/content/docs/loki/next -p 3002:3002 $(IMAGE) /bin/bash -c 'mkdir -p content/docs/grafana/next/ && touch content/docs/grafana/next/menu.yaml && make server-quick' |
There was a problem hiding this comment.
Out of curiosity why is the touch required?
There was a problem hiding this comment.
I'd guess to update the file timestamp and signal the subsequent make command that it's dependencies need to be built.
owen-d
approved these changes
Jul 8, 2021
| .PHONY: docs-next | ||
| docs-next: | ||
| docker pull ${IMAGE} | ||
| docker run --rm -it -v ${PWD}/sources:/hugo/content/docs/loki/next -p 3002:3002 $(IMAGE) /bin/bash -c 'mkdir -p content/docs/grafana/next/ && touch content/docs/grafana/next/menu.yaml && make server-quick' |
There was a problem hiding this comment.
I'd guess to update the file timestamp and signal the subsequent make command that it's dependencies need to be built.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This target builds local docs as they should look for commits that are
placed into the main branch, showing the next up, but not yet released
Loki docs.