fixes a badly referenced variable name in StepEvaluator code #3996
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jeschkies
reviewed
Jul 14, 2021
| @@ -9,7 +9,7 @@ import ( | |||
| // StepEvaluator evaluate a single step of a query. | |||
| type StepEvaluator interface { | |||
| // while Next returns a promql.Value, the only acceptable types are Scalar and Vector. | |||
| Next() (bool, int64, promql.Vector) | |||
| Next() (ok bool, ts int64, vec promql.Vector) | |||
There was a problem hiding this comment.
Neat! I didn't know one could name return parameters.
jeschkies
approved these changes
Jul 14, 2021
sandeepsukhani
approved these changes
Jul 19, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While poking around some sharding code I noticed a variable was referenced incorrectly. This didn't result in a bug, but made reading this piece of code confusing/counterintuitive. This PR fixes the variable naming and gives the interface a hint.
cc @jeschkies in case you're curious