Revise portions of the docs LogQL section #4012
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jeschkies
reviewed
Jul 20, 2021
Comment on lines
+177
to
+179
| For example, | ||
| while the results will be the same, | ||
| the query specified with |
There was a problem hiding this comment.
This would be an example 🙂
cyriltovena
reviewed
Jul 20, 2021
kb000
reviewed
Oct 18, 2023
|
|
||
| #### Offset modifier |
There was a problem hiding this comment.
The Offset modifier section got lost in this PR.
kb000
added a commit
to kb000/loki
that referenced
this pull request
Oct 18, 2023
Bring back offset modifier doc section from grafana#3455 and lost in grafana#4012
JStickler
pushed a commit
that referenced
this pull request
Oct 19, 2023
Bring back offset modifier doc section from #3455 and lost in #4012 **What this PR does / why we need it**: **Which issue(s) this PR fixes**: Fixes regression from #2785 **Special notes for your reviewer**: **Checklist** - [x] Reviewed the [`CONTRIBUTING.md`](https://github.com/grafana/loki/blob/main/CONTRIBUTING.md) guide (**required**) - [x] Documentation added - [ ] Tests updated **N/A** - [ ] `CHANGELOG.md` updated **N/A** - [ ] If the change is worth mentioning in the release notes, add `add-to-release-notes` label **N/A** - [ ] Changes that require user attention or interaction to upgrade are documented in `docs/sources/setup/upgrade/_index.md` **N/A** - [ ] For Helm chart changes bump the Helm chart version in `production/helm/loki/Chart.yaml` and update `production/helm/loki/CHANGELOG.md` and `production/helm/loki/README.md`. [Example PR](d10549e) **N/A**
7 tasks
grafanabot
pushed a commit
that referenced
this pull request
Oct 19, 2023
Bring back offset modifier doc section from #3455 and lost in #4012 **What this PR does / why we need it**: **Which issue(s) this PR fixes**: Fixes regression from #2785 **Special notes for your reviewer**: **Checklist** - [x] Reviewed the [`CONTRIBUTING.md`](https://github.com/grafana/loki/blob/main/CONTRIBUTING.md) guide (**required**) - [x] Documentation added - [ ] Tests updated **N/A** - [ ] `CHANGELOG.md` updated **N/A** - [ ] If the change is worth mentioning in the release notes, add `add-to-release-notes` label **N/A** - [ ] Changes that require user attention or interaction to upgrade are documented in `docs/sources/setup/upgrade/_index.md` **N/A** - [ ] For Helm chart changes bump the Helm chart version in `production/helm/loki/Chart.yaml` and update `production/helm/loki/CHANGELOG.md` and `production/helm/loki/README.md`. [Example PR](d10549e) **N/A** (cherry picked from commit 8645519)
JStickler
pushed a commit
that referenced
this pull request
Oct 19, 2023
Backport 8645519 from #10960 --- Bring back offset modifier doc section from #3455 and lost in #4012 **What this PR does / why we need it**: **Which issue(s) this PR fixes**: Fixes regression from #2785 **Special notes for your reviewer**: **Checklist** - [x] Reviewed the [`CONTRIBUTING.md`](https://github.com/grafana/loki/blob/main/CONTRIBUTING.md) guide (**required**) - [x] Documentation added - [ ] Tests updated **N/A** - [ ] `CHANGELOG.md` updated **N/A** - [ ] If the change is worth mentioning in the release notes, add `add-to-release-notes` label **N/A** - [ ] Changes that require user attention or interaction to upgrade are documented in `docs/sources/setup/upgrade/_index.md` **N/A** - [ ] For Helm chart changes bump the Helm chart version in `production/helm/loki/Chart.yaml` and update `production/helm/loki/CHANGELOG.md` and `production/helm/loki/README.md`. [Example PR](d10549e) **N/A** Co-authored-by: Kevin Burek <kb000@users.noreply.github.com>
rhnasc
pushed a commit
to inloco/loki
that referenced
this pull request
Apr 12, 2024
Bring back offset modifier doc section from grafana#3455 and lost in grafana#4012 **What this PR does / why we need it**: **Which issue(s) this PR fixes**: Fixes regression from grafana#2785 **Special notes for your reviewer**: **Checklist** - [x] Reviewed the [`CONTRIBUTING.md`](https://github.com/grafana/loki/blob/main/CONTRIBUTING.md) guide (**required**) - [x] Documentation added - [ ] Tests updated **N/A** - [ ] `CHANGELOG.md` updated **N/A** - [ ] If the change is worth mentioning in the release notes, add `add-to-release-notes` label **N/A** - [ ] Changes that require user attention or interaction to upgrade are documented in `docs/sources/setup/upgrade/_index.md` **N/A** - [ ] For Helm chart changes bump the Helm chart version in `production/helm/loki/Chart.yaml` and update `production/helm/loki/CHANGELOG.md` and `production/helm/loki/README.md`. [Example PR](grafana@d10549e) **N/A**
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This the first of what may be many PRs to update the docs section on LogQL. This PR improves the phrasing and presentation of many examples. It introduces a diagram to show the structure of a query. It standardizes some use of terms, and it relies a little bit less on readers who are familiar with PromQL.