Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: fix link to Promtail documentation #4293

Merged
merged 2 commits into from
Sep 9, 2021
Merged

docs: fix link to Promtail documentation #4293

merged 2 commits into from
Sep 9, 2021

Conversation

Birdi7
Copy link
Contributor

@Birdi7 Birdi7 commented Sep 8, 2021

What this PR does / why we need it:

The current link to Promtail installation documentation in the file leads to 404 error. I observed that the ../docs/clients/ folder was refactored into ../docs/sources/clients at same time in past. However, the loki/docs/sources/clients/promtail/installation.md file is not very convenient if we talk about UX. So, I've replaced the wrong link with the one to rendered beautiful documentation

The current link to Promtail installation documentation in the file leads to 404 error. I observed that the `../docs/clients/` folder was refactored into `../docs/sources/clients` at same time in past. However, the `loki/docs/sources/clients/promtail/installation.md` file is not very convenient if we talk about UX. So, I've replaced the wrong link with the one to rendered beautiful documentation
@Birdi7 Birdi7 requested a review from a team as a code owner September 8, 2021 19:24
@CLAassistant
Copy link

CLAassistant commented Sep 8, 2021

CLA assistant check
All committers have signed the CLA.

Copy link
Contributor

@dannykopping dannykopping left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks very much for your contribution @Birdi7!

Left you a comment

production/README.md Outdated Show resolved Hide resolved
Copy link
Contributor

@dannykopping dannykopping left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot @Birdi7!

@dannykopping dannykopping merged commit e3b35df into grafana:main Sep 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants