restores for state at seconds(now-forDuration) #4479
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes a bug where we were incorrectly restoring for state. Loki will try to synthesize a historical
ALERTS_FOR_STATE
upon first evaluation (i.e. after restart) by evaluating the rule at bothnow-for_duration
andnow
, which should allow it to recover after restarts, etc. This PR fixes a bug where the returned sample value in this time series was the millisecond timestamp ofnow
, rather than the unix seconds representation ofnow-for_duration
. I tested this locally with the following rule, which now successfully tries to alert before the 10m duration is up.