Replacing go-kit/kit/log with go-kit/log #4484
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Danny Kopping <danny.kopping@grafana.com>
added 4 commits
October 15, 2021 17:12
Signed-off-by: Danny Kopping <danny.kopping@grafana.com>
Cleaning go mod Signed-off-by: Danny Kopping <danny.kopping@grafana.com>
Signed-off-by: Danny Kopping <danny.kopping@grafana.com>
Signed-off-by: Danny Kopping <danny.kopping@grafana.com>
slim-bean
reviewed
Oct 15, 2021
| @@ -48,6 +48,12 @@ linters-settings: | |||
| goimports: | |||
| local-prefixes: github.com/grafana/loki/pkg | |||
|
|
|||
| depguard: | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Re-implementing #4164 after it went stale
What this PR does / why we need it:
This PR aims to align Loki with Prometheus (see prometheus/prometheus#8927) in its use of
go-kit's logger.go-kit/kit/logwas split out intogo-kit/log, and that's all we use ofgo-kitostensibly.Which issue(s) this PR fixes:
N/A
Special notes for your reviewer:
This bit me recently when trying to understand why debug logs were printed when I'd explicitly set
-log.level=info. It turns out that if a log message is written from within the vendored Prometheus code, it uses the newergo-kit/log, so this coercion mysterious fails even though the type seems correct. That was a fun one to debug 🙃I upgraded
weaveworks/commonafter weaveworks/common#226 was merged, since it was suffering from the same issue, same for cortex (cortexproject/cortex#4421) although that was revendored yesterday.Checklist