Modify lambda-promtail docs based on rewrite. #4539
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Callum Styan <callumstyan@gmail.com>
cstyan
requested review from
dannykopping,
owen-d and
slim-bean
as code owners
owen-d
approved these changes
Oct 25, 2021
|
|
||
| Instead we can pipeline Cloudwatch logs to a set of Promtails, which can mitigate these problem in two ways: | ||
| There's also a flag to keep the log group label when propagating the logs, which defaults to false. |
There was a problem hiding this comment.
Suggested change
| There's also a flag to keep the log group label when propagating the logs, which defaults to false. | |
| There's also a flag to keep the log stream label when propagating the logs, which defaults to false. This can be helpful when the cardinality is too large, such as the case of a log per lambda invocation. |
|
|
||
| To keep the log group label add `-var "keep_stream=true"`. | ||
|
|
||
| Note that the automatic subscription filter creation to multiple log groups is done without the addition of any regex filtering on the logs contents. |
There was a problem hiding this comment.
re-word this sentence? I'm not sure what it means.
|
|
||
| ## Multiple Promtail Deployment | ||
|
|
||
| Disclaimer: The following section is only relevant for older versions of Loki that cannot accept out of order logs. |
There was a problem hiding this comment.
Suggested change
| Disclaimer: The following section is only relevant for older versions of Loki that cannot accept out of order logs. | |
| **Disclaimer: The following section is only relevant for older versions of Loki that cannot accept out of order logs.** |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds simplified "getting started" type steps for the new lambda-promtail changes. I tried to keep the old docs but move them around + make it clear that the the multiple promtail + load balancer deployment was no longer required and only necessary for older version of Loki that do not support out of order ingestion.
Signed-off-by: Callum Styan callumstyan@gmail.com